-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IN
and NOT IN
#1344
Implement IN
and NOT IN
#1344
Conversation
maybe later.
Figure out the constantness of the result...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
+ Coverage 88.95% 88.99% +0.04%
==========================================
Files 329 329
Lines 29090 29155 +65
Branches 3230 3236 +6
==========================================
+ Hits 25877 25947 +70
+ Misses 2060 2055 -5
Partials 1153 1153 ☔ View full report in Codecov by Sentry. |
correct behavior with SetOfIntervals.
# Conflicts: # src/parser/sparqlParser/generated/SparqlAutomaticParser.cpp
# Conflicts: # test/SparqlAntlrParserTest.cpp
IN
and NOT IN
# Conflicts: # src/engine/sparqlExpressions/LiteralExpression.h # src/engine/sparqlExpressions/SparqlExpressionTypes.h # src/util/Views.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-1 with Johannes, this looks great and works fine, some minor changes left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny change left
Quality Gate passedIssues Measures |
No description provided.