-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement [...]
(blank node property lists) in SPARQL queries
#1279
Implement [...]
(blank node property lists) in SPARQL queries
#1279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two commens from a quick glance over the PR
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1279 +/- ##
==========================================
+ Coverage 87.63% 87.68% +0.04%
==========================================
Files 308 307 -1
Lines 28008 28061 +53
Branches 3138 3146 +8
==========================================
+ Hits 24545 24604 +59
+ Misses 2324 2317 -7
- Partials 1139 1140 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thorough 1-1 with Johannes, awesome work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, only minor changes left now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another milestone taken, thanks a lot!
[...]
(blank node property lists) in SPARQL queries
Quality Gate passedIssues Measures |
Full implementation of everything involving
[...]
(blank nodes and blank node property lists) in a SPARQL query. For example, https://qlever.cs.uni-freiburg.de/wikidata/WyEKHP or https://qlever.cs.uni-freiburg.de/wikidata/Ewivke.In particular, blank nodes (like
_:bla
) and anonymous blank nodes (like[]
) in a SPARQL query now behave like a variable, as they should. So far, they never matched anything, which was a bug. Fixes #1278.