Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement [...] (blank node property lists) in SPARQL queries #1279

Merged
merged 9 commits into from
Feb 16, 2024

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Feb 13, 2024

Full implementation of everything involving [...] (blank nodes and blank node property lists) in a SPARQL query. For example, https://qlever.cs.uni-freiburg.de/wikidata/WyEKHP or https://qlever.cs.uni-freiburg.de/wikidata/Ewivke.

In particular, blank nodes (like _:bla) and anonymous blank nodes (like []) in a SPARQL query now behave like a variable, as they should. So far, they never matched anything, which was a bug. Fixes #1278.

@hannahbast hannahbast changed the title Correctly implement blank and anonymous nodes in SPARQL queries Correctly implement blank nodes in SPARQL queries Feb 13, 2024
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two commens from a quick glance over the PR

src/parser/data/GraphTerm.h Show resolved Hide resolved
src/parser/sparqlParser/SparqlQleverVisitor.cpp Outdated Show resolved Hide resolved
@hannahbast hannahbast marked this pull request as ready for review February 14, 2024 11:08
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (f9c9ff4) 87.63% compared to head (5df9f46) 87.68%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/parser/sparqlParser/SparqlQleverVisitor.cpp 97.39% 2 Missing and 3 partials ⚠️
src/parser/ParsedQuery.cpp 87.50% 0 Missing and 1 partial ⚠️
src/parser/data/GraphTerm.h 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
+ Coverage   87.63%   87.68%   +0.04%     
==========================================
  Files         308      307       -1     
  Lines       28008    28061      +53     
  Branches     3138     3146       +8     
==========================================
+ Hits        24545    24604      +59     
+ Misses       2324     2317       -7     
- Partials     1139     1140       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thorough 1-1 with Johannes, awesome work!

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, only minor changes left now

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another milestone taken, thanks a lot!

@hannahbast hannahbast changed the title Correctly implement blank nodes in SPARQL queries Implement [...] (blank node property lists) in SPARQL queries Feb 15, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
10 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hannahbast hannahbast merged commit a70652e into ad-freiburg:master Feb 16, 2024
18 checks passed
@joka921 joka921 deleted the correct-anonymous-nodes branch February 28, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in implementation of [] (anonymous blank node) for SPARQL queries
2 participants