Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement STRSTARTS, STRENDS, STRBEFORE, STRAFTER, and CONTAINS #1065

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Implement STRSTARTS, STRENDS, STRBEFORE, STRAFTER, and CONTAINS #1065

merged 10 commits into from
Aug 22, 2023

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Aug 22, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 91.95% and project coverage change: +0.08% 🎉

Comparison is base (e3e236a) 78.35% compared to head (754fd26) 78.43%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   78.35%   78.43%   +0.08%     
==========================================
  Files         275      275              
  Lines       25797    25865      +68     
  Branches     3157     3166       +9     
==========================================
+ Hits        20212    20287      +75     
+ Misses       4380     4372       -8     
- Partials     1205     1206       +1
Files Changed Coverage Δ
...e/sparqlExpressions/SparqlExpressionValueGetters.h 91.89% <0.00%> (-8.11%) ⬇️
src/engine/sparqlExpressions/StringExpressions.cpp 96.05% <98.43%> (+0.86%) ⬆️
src/parser/sparqlParser/SparqlQleverVisitor.cpp 91.63% <100.00%> (+0.09%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hannahbast
hannahbast requested changes Aug 22, 2023
View reviewed changes
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Minor changes left

hannahbast
hannahbast approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@hannahbast hannahbast changed the title Add STRARTS, STRENDS, CONTAINS, STRAFTER, and STRBEFORE expressions Implement STRSTARTS, STRENDS, STRBEFORE, STRAFTER, and CONTAINS Aug 22, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
2.5% 2.5% Duplication

@hannahbast hannahbast merged commit a77ac86 into ad-freiburg:master Aug 22, 2023
@joka921 joka921 deleted the simpler-expression-impls branch December 7, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahbast hannahbast hannahbast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joka921 @hannahbast