Skip to content

Commit

Permalink
Optimize Dockerfile and add action for pushing it to DockerHub (#16)
Browse files Browse the repository at this point in the history
Add a GitHub action that automatically builds an image and pushes it to the docker registry. Use the occasion to optimize the `Dockerfile`.
  • Loading branch information
Qup42 authored Dec 17, 2024
1 parent 8c28800 commit 9beca55
Show file tree
Hide file tree
Showing 2 changed files with 72 additions and 15 deletions.
60 changes: 60 additions & 0 deletions .github/workflows/build-docker.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
name: Docker build and publish

on:
push:
branches: [ master ]

concurrency:
# We want all containers to be pushed. Don't cancel any concurent jobs.
group: '${{ github.workflow }} @ ${{ github.sha}}'
cancel-in-progress: true

jobs:
docker:
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
with:
submodules: 'recursive'
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Login to Docker Hub
if: github.event_name != 'pull_request'
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Get short SHA
id: sha
run: echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
- name: Generate image metadata
id: meta
uses: docker/metadata-action@v5
env:
# We build multiplatform images which have an image index above the
# image manifests. Attach the annotations directly to the image index.
DOCKER_METADATA_ANNOTATIONS_LEVELS: "index"

- name: Build and push
if: github.event_name != 'pull_request'
uses: docker/build-push-action@v6
with:
context: .
target: runtime
platforms: linux/amd64,linux/arm64
push: true
# We have to explicitly add the "qlever-petrimaps:latest" tag for it to work correctly,
# see e.g. https://stackoverflow.com/questions/27643017/do-i-need-to-manually-tag-latest-when-pushing-to-docker-public-repository
tags: >
adfreiburg/qlever-petrimaps:latest,
adfreiburg/qlever-petrimaps:${{ github.ref_name }},
adfreiburg/qlever-petrimaps:commit-${{ steps.sha.outputs.sha_short }},
# Set annotations and labels that conform to the OpenContainers
# Annotations Spec
annotations: ${{ steps.meta.outputs.annotations }}
labels: ${{ steps.meta.outputs.labels }}

27 changes: 12 additions & 15 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,27 +1,24 @@
FROM ubuntu:20.04
FROM ubuntu:24.04 AS builder

ENV DEBIAN_FRONTEND=noninteractive

RUN apt-get update \
&& apt-get install --no-install-recommends -y\
ca-certificates \
make \
cmake \
xxd \
# careful, OpenSSL is not thread safe, you MUST use GnuTLS
libcurl4-gnutls-dev \
default-jre \
libpng-dev \
libomp-dev \
g++
# NOTE: OpenSSL is not thread safe, you MUST use GnuTLS.
RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates make cmake xxd libcurl4-gnutls-dev default-jre libpng-dev libomp-dev g++

COPY CMakeLists.txt /
ADD cmake /cmake
ADD src /src
ADD web /web

RUN mkdir build && cd build && cmake .. && make -j8
RUN mkdir build && cd build && cmake .. && make -j

FROM ubuntu:24.04 AS runtime

ENV DEBIAN_FRONTEND=noninteractive

WORKDIR /
RUN apt update && apt install -y --no-install-recommends ca-certificates xxd libgomp1 libpng-dev libcurl4-gnutls-dev dumb-init && rm -rf /var/lib/apt/lists/*
COPY --from=builder /build/petrimaps /petrimaps

ENTRYPOINT ["./build/petrimaps"]
ENTRYPOINT ["/usr/bin/dumb-init", "--"]
CMD ["/petrimaps"]

0 comments on commit 9beca55

Please sign in to comment.