Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to specify optional Feature section #8

Merged
merged 3 commits into from
Aug 29, 2013

Conversation

tddmonkey
Copy link

I've added in the ability to add an optional Feature header at the within the file, so you can now do something like:

Feature: As a Yadda user I want to add a feature block to describe the overall story for the scenarios

@cressie176
Copy link
Member

Thanks for contributing. I'll pull and get a new release out in the next couple of days.

@tddmonkey
Copy link
Author

Thanks dude.

We've (shazam) picked Yadda as our BDD tool of choice so will more than likely have more contributions to make. Do you have an architectural vision we should stick to? For example, adding examples tables?

@cressie176
Copy link
Member

That's great news! Re the architectural vision - I've created a Notes for Contributors page in the wiki. Hope it's not overly prescriptive (please say if you think it is).

I've also created some issues for enhancements I've been thinking of. It should help give you an idea of where I think Yadda should progress.

Lastly sorry I've not merge the pull request yet. Day job has been taking priority this week.

@cressie176 cressie176 merged commit 43bea36 into acuminous:master Aug 29, 2013
@cressie176
Copy link
Member

Included in 0.4.6 - sorry it took so long.

FYI I'm thinking about changing the mocha plugin to something like

feature('features/bottles.feature', function(feature) {
   var library = require('./lib/bottles-library');
   var yadda = new Yadda(library);
   scenarios(scenario, done) {
      yadda.yadda(scenario.steps, done);
   }
}

Where the feature method calls Mocha's describe method with the feature text and the scenarios method repeatedly calls Mocha's it method with the scenario text.

What do you think?

@tddmonkey
Copy link
Author

Sorry dude, been super busy so not had chance to look at anything yadda related. I read your notes from contributors, agree 100% with everything you say there and it's nice to see someone that agrees with me :). I'll try to get on at looking at some stuff soon

@cressie176
Copy link
Member

LOL. You and me both. Something that would be really useful is a webdriver example, but only if you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants