Fix electron builds in CI #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
fix-electron-builds
branch
from
7555f96 to
c0837ec
Compare
TomAFrench
force-pushed
the
fix-electron-builds
branch
2 times, most recently
from
225767d to
9bbd54f
Compare
TomAFrench
force-pushed
the
fix-electron-builds
branch
from
c23339c to
f4a7d5d
Compare
✅ Deploy Preview for actualbudget canceled.
|
|
Seems that this is not yet ready to be merged. CI jobs are failing. I'll leave it open for now in case anyone wants to pick it up. |
|
👋 Thanks for starting this initiative. It's quite a complex one. Given this has been stale for quite some time now - I'll close it. But please feel free to reopen if you resume working on it. Also created a tracking ticket so we could use this work as a point of reference in case anyone else wants to pick it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds of the desktop app are currently failing in CI but work locally. It seems like this has something to do with migrating to yarnv3