Fix dangerous usage of std::forward
#864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While debugging the CI failures in acts-project#859, I found out that the problem was not with my code, but rather that there is a critical failure with the use of `std::forward` in `host_container.cpp`, which causes objects passed to `push_back` as l-value references to be inadvertently converted to r-value references. This commit fixes the bug in `host_container.hpp`. The `nseed_performance_writer.cpp` contained a much less serious mistake which I also fixed.
|
niermann999
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the CI failures in #859, I found out that the problem was not with my code, but rather that there is a critical failure with the use of
std::forwardinhost_container.hpp, which causes objects passed topush_backas l-value references to be inadvertently converted to r-value references. This commit fixes the bug inhost_container.hpp. Thenseed_performance_writer.cppcontained a much less serious mistake which I also fixed.