fix: Type printing #928
Merged
fix: Type printing #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope that this will fix the compilation error on the detray update in traccc |
|
... or maybe the detray CI does compile this code, but somehow does not mind the same things as the traccc CI |
niermann999
force-pushed
the
fix-type-printing
branch
from
c5cc581 to
84e1383
Compare
|
stephenswat
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use std::sentinel_t in type printing, since the two iterators that std::string can be constructed from need to have the same type. Unfortunately, the detray cuda CI builds are running gcc 13.x, which did not catch this, and the gitlab CUDA CI, which is using gcc 11.4 and could catch this, is not compiling the detector reader but only unit and integration tests