ref: Adapt to client interface and allow to compile multiple plugins side by side #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
niermann999
force-pushed
the
ref-adapt-client-interface
branch
11 times, most recently
from
af5e110
to
c02babd
Compare
|
Let's merge #132 first! That should make it a lot easier (for me) to review this one... 🤔 |
niermann999
force-pushed
the
ref-adapt-client-interface
branch
6 times, most recently
from
77f2fec
to
ba907f6
Compare
krasznaa
requested changes
Nov 25, 2024
niermann999
force-pushed
the
ref-adapt-client-interface
branch
2 times, most recently
from
7c3b33c
to
59a9b40
Compare
krasznaa
reviewed
Nov 26, 2024
niermann999
force-pushed
the
ref-adapt-client-interface
branch
4 times, most recently
from
9c89912
to
4ba6777
Compare
krasznaa
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
I'm a little worried about the many templated layers that the math functions need to go over, but don't have a better proposal at the moment. So, let's see how this fares.
As we discussed today, I'll start doing some oneAPI 2025.0.0 updates of my own while you work on Detray. 😉
niermann999
force-pushed
the
ref-adapt-client-interface
branch
4 times, most recently
from
2a58e77
to
0f80d49
Compare
niermann999
force-pushed
the
ref-adapt-client-interface
branch
from
0f80d49
to
5d84a19
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide the generic function overloads behind the functions of specific plugins, because they would otherwise always take precedence when using multiple plugins side by side.