-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add troubleshooting section for Spack #3881
base: main
Are you sure you want to change the base?
docs: Add troubleshooting section for Spack #3881
Conversation
WalkthroughThe documentation for building with Spack has been expanded to provide more comprehensive guidance for users. A new section on running DD4hep has been added, explaining how to properly initialize the environment by sourcing a specific shell script. A troubleshooting section has also been introduced, addressing potential issues users might encounter, particularly related to DD4hep factory detection. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Actually, our CMake will produce a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/misc/spack.md (1)
91-92
: Expand the introduction, we should.More context about troubleshooting section's purpose, helpful it would be.
Suggest this modification, I do:
-The following are some common problems you may encounter using Spack to build -ACTS. +The following section addresses common problems encountered when using Spack to build +and run ACTS. If persist your issues do, seek guidance in the Spack channel on ACTS Mattermost, you should.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/misc/spack.md
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/misc/spack.md
[style] ~65-~65: Consider a shorter alternative to avoid wordiness.
Context: ...ormal using CMake. ### Running DD4hep In order to run code depending on DD4hep, you may n...
(IN_ORDER_TO_PREMIUM)
🔇 Additional comments (1)
docs/misc/spack.md (1)
96-104
: Clear and helpful, this error description is.
Well structured the error documentation is. Example and solution, provided they are. Approve this section, I do.
e24cf23
to
e93b3a3
Compare
Updated to mention |
As @Cas1997 discovered, the DD4hep executables need some additional setup when using a Spack install. This commit adds documentation to the Spack page on how to do this, and on how to debug related issues.
As @Cas1997 discovered, the DD4hep executables need some additional setup when using a Spack install. This commit adds documentation to the Spack page on how to do this, and on how to debug related issues.
Summary by CodeRabbit