refactor: Reworked HitSelector in Examples
#3836
Draft
+221
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
Component - Examples
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 10, 2024
This helper is not used anywhere and should be either removed or made use of. I opted to remove it for now as finding all the spots where it could be used is much more tedious and time consuming. Discovered in #3836
|
andiwand
changed the title
MeasurementSelector and reworked HitSelector for ExamplesHitSelector for Examples
andiwand
changed the title
HitSelector for ExamplesHitSelector in Examples
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
This helper is not used anywhere and should be either removed or made use of. I opted to remove it for now as finding all the spots where it could be used is much more tedious and time consuming. Discovered in acts-project#3836
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 20, 2024
This helper is not used anywhere and should be either removed or made use of. I opted to remove it for now as finding all the spots where it could be used is much more tedious and time consuming. Discovered in acts-project#3836
| } | ||
| } | ||
|
|
||
| SimHitContainer selectedHits(unorderedHits.begin(), unorderedHits.end()); |
There was a problem hiding this comment.
In principle one could optimize the construction by sorting the vector and provide this boost::container::sorted_range_t tag (or similar), might be benefitial in for very high pile-up situations with a lot of hits...
There was a problem hiding this comment.
And I think we can reserve the space in the SimHitContainer, right?
| @@ -138,6 +129,11 @@ class MeasurementContainer { | |||
| return getMeasurement<Size>(addMeasurement(Size, geometryId)); | |||
| } | |||
|
|
|||
| template <MeasurementConcept OtherDerived> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivations is that one can select hits to constrain the reconstruction to a subset of them. This can be especially useful for studies which look at different pile-up. Pile-up vertices have consecutive primary vertex IDs so one can simulate for example pile-up 200 and then reconstruct only a subset of them.
Bocked by
CalculateResiduals.hpp#3837