-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Remove BinningType #3826
base: main
Are you sure you want to change the base?
refactor!: Remove BinningType #3826
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@paulgessinger - as discussed, this would be the first step towards phasing the |
Awesome! I think I need to go through this in detail so we can hopefully catch searchable replace errors. |
187dd9f
to
4e9fca1
Compare
@asalzburger I'll look through this once the compilation / CI issues are overcome. |
Absolutely, I am still chasing the one or other case where it fails, I will ping you and un-draft as soon as I am ready. |
This PR removes
BinningType
and puts everything onto one set of Axis definitions, which are in a new file:AxisDefinitions.hpp
After this massive change, only there enums remain:
AxisType
as ofEquidistant
andVariable
AxisBoundaryType
as ofOpen
,Bound
andClosed
AxisDirection
which replaces the formerBinningValue
enumChanges many many files, and potentially introduces a schema evolution for material files and digitisation files, because
AxisBoundaryType
has an offset of 1 with respect toBinninOption
Will need some adaption to client code, I will create a cheat sheet.
--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!