chore(tests): brush over surface tests #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
reviewed
Oct 24, 2024
AJPfleger
force-pushed
the
tests-refactor
branch
from
1bb2674 to
e1750b7
Compare
AJPfleger
force-pushed
the
tests-refactor
branch
from
cce4e4f to
e95149d
Compare
andiwand
reviewed
Oct 25, 2024
AJPfleger
force-pushed
the
tests-refactor
branch
from
8410d7b to
2f6c713
Compare
andiwand
approved these changes
Oct 25, 2024
|
acts-project-service
added
the
Breaks Athena build
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 10, 2024
blocked: - #3783 Asked co-pilot to summarise the PR: Summary: The pull request aims to refactor the code to use mathematical constants from the C++20 <numbers> header, replacing existing instances of M_PI with std::numbers::pi. The changes span multiple files, primarily focusing on improving the consistency and modernity of mathematical constant usage across the codebase.
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
- removed `Tests/UnitTests/Core/Surfaces/BoundaryToleranceTestsRefs.hpp` because it was unused. - fixed typo in the testing numbers in `Tests/UnitTests/Core/Surfaces/TrapezoidBoundsTests.cpp` - enable tests, that were planned but not finished back in the days
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
…t#3781) blocked: - acts-project#3783 Asked co-pilot to summarise the PR: Summary: The pull request aims to refactor the code to use mathematical constants from the C++20 <numbers> header, replacing existing instances of M_PI with std::numbers::pi. The changes span multiple files, primarily focusing on improving the consistency and modernity of mathematical constant usage across the codebase.
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 20, 2024
…t#3781) blocked: - acts-project#3783 Asked co-pilot to summarise the PR: Summary: The pull request aims to refactor the code to use mathematical constants from the C++20 <numbers> header, replacing existing instances of M_PI with std::numbers::pi. The changes span multiple files, primarily focusing on improving the consistency and modernity of mathematical constant usage across the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests/UnitTests/Core/Surfaces/BoundaryToleranceTestsRefs.hppbecause it was unused.Tests/UnitTests/Core/Surfaces/TrapezoidBoundsTests.cpp