Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove a number of Sonar issues #3780

Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix: Remove a number of Sonar issues #3780

merged 3 commits into from
Oct 28, 2024

Conversation

paulgessinger
Copy link
Member

No description provided.

@paulgessinger paulgessinger added this to the next milestone Oct 24, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module labels Oct 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

📊: Physics performance monitoring for 92f9b07

Full contents

physmon summary

benjaminhuth
benjaminhuth approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
16.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit d155d23 into acts-project:main Oct 28, 2024
42 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [d155d23]

🔴 Some tests have failed!

Please investigate the pipeline!

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 test_ActsDumpGeometryIdentifiers
🟢 test_ActsCheckObjectCountsCachedWorkflow
🔴 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🔴 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🔴 test_ActsValidateResolvedTracks
🔴 test_ActsValidateTracks
🔴 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🔴 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_unit_tests

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 29, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.4.0, v37.3.0 Nov 8, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
@paulgessinger @Rosie-Hasan
fix: Remove a number of Sonar issues (acts-project#3780)
1aed953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminhuth benjaminhuth benjaminhuth approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Milestone
v37.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @acts-project-service @benjaminhuth