build: Unconditionally load Boost in CMake config #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Infrastructure
|
@andiwand if you want to have a laugh at how hilariously terrible CMake is. |
|
defaults all the way - love it <3 |
andiwand
reviewed
Oct 23, 2024
andiwand
previously approved these changes
Oct 23, 2024
stephenswat
force-pushed
the
build/install_load_boost
branch
2 times, most recently
from
fe8e598 to
c130a98
Compare
Currently, as @krasznaa discovered, the finding of the Boost dependency in an installed version of Acts (i.e., through `ActsConfig.cmake` uses the `@ACTS_USE_SYSTEM_BOOST@` template, but this variable no longer exists. CMake, in its infinite wisdom, silently ignores this, producing `if()`, which it _again_ silently accepts and which apparently evaluates to false, so Boost is never loaded. This commit fixes the issue by ensuring that Boost is loaded unconditionally.
|
I'm a bit confused why the downstream project test didn't discover this, actually. |
paulgessinger
approved these changes
Oct 24, 2024
|
acts-project-service
added
the
Fails Athena tests
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
Currently, as @krasznaa discovered, the finding of the Boost dependency in an installed version of Acts (i.e., through `ActsConfig.cmake` uses the `@ACTS_USE_SYSTEM_BOOST@` template, but this variable no longer exists. CMake, in its infinite wisdom, silently ignores this, producing `if()`, which it _again_ silently accepts and which apparently evaluates to false, so Boost is never loaded. This commit fixes the issue by ensuring that Boost is loaded unconditionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, as @krasznaa discovered, the finding of the Boost dependency in an installed version of Acts (i.e., through
ActsConfig.cmakeuses the@ACTS_USE_SYSTEM_BOOST@template, but this variable no longer exists.CMake, in its infinite wisdom, silently ignores this, producing
if(), which it again silently accepts and which apparently evaluates to false, so Boost is never loaded.This commit fixes the issue by ensuring that Boost is loaded unconditionally.