Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow detray sterile/non-sterile propagation #3652

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

asalzburger
Copy link
Contributor

This PR remodels the detray Propagation validation, it allows to switch the propagation to sterile for timing measurements, and changes the template to stepper while pushing the inspectors and actors to the instantiation of the propagation implantation.

On ODD on can see the effects of the surface grids now:

Without surface grids:

15:41:18    Sequencer      INFO      Average time per event: 7.804390 ms/event

With surface grids:

15:45:31    Sequencer      INFO      Average time per event: 1.402830 ms/event

Great job! @EleniXoch @niermann999

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Sep 26, 2024
@asalzburger asalzburger added this to the next milestone Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

📊: Physics performance monitoring for 09b2e19

Full contents

physmon summary

niermann999
niermann999 previously approved these changes Sep 27, 2024
Copy link
Contributor

@niermann999 niermann999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments that don't need to be addressed in this PR

@asalzburger asalzburger force-pushed the feat-detray-propagation branch from 0d84be7 to f096c32 Compare September 27, 2024 08:57
@acts-policybot acts-policybot bot dismissed niermann999’s stale review September 27, 2024 08:57

Invalidated by push of f096c32

@kodiakhq kodiakhq bot merged commit 6e08612 into acts-project:main Sep 27, 2024
43 checks passed
Copy link

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Sep 27, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants