-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow detray sterile/non-sterile propagation #3652
Merged
kodiakhq
merged 5 commits into
acts-project:main
from
asalzburger:feat-detray-propagation
Sep 27, 2024
Merged
feat: allow detray sterile/non-sterile propagation #3652
kodiakhq
merged 5 commits into
acts-project:main
from
asalzburger:feat-detray-propagation
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
previously approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments that don't need to be addressed in this PR
Examples/Algorithms/Traccc/include/ActsExamples/Traccc/DetrayPropagator.hpp
Show resolved
Hide resolved
Examples/Algorithms/Traccc/include/ActsExamples/Traccc/DetrayPropagator.hpp
Show resolved
Hide resolved
Examples/Algorithms/Traccc/include/ActsExamples/Traccc/DetrayPropagator.hpp
Show resolved
Hide resolved
0d84be7
to
f096c32
Compare
Invalidated by push of f096c32
niermann999
approved these changes
Sep 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Examples
Affects the Examples module
Fails Athena tests
This PR causes a failure in the Athena tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remodels the
detray
Propagation validation, it allows to switch the propagation tosterile
for timing measurements, and changes the template to stepper while pushing the inspectors and actors to the instantiation of the propagation implantation.On ODD on can see the effects of the surface grids now:
Without surface grids:
15:41:18 Sequencer INFO Average time per event: 7.804390 ms/event
With surface grids:
15:45:31 Sequencer INFO Average time per event: 1.402830 ms/event
Great job! @EleniXoch @niermann999