Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(geo): Surface::isOnSurface gets tolerance parameter #3544

Merged
merged 3 commits into from
Aug 23, 2024
Merged

feat(geo): Surface::isOnSurface gets tolerance parameter #3544

merged 3 commits into from
Aug 23, 2024

Conversation

paulgessinger
Copy link
Member

This parameter gets piped through to the localToGlobal call. Defaults are unchanged.

@paulgessinger paulgessinger added this to the next milestone Aug 22, 2024
@paulgessinger paulgessinger requested a review from andiwand August 22, 2024 17:43
@paulgessinger paulgessinger mentioned this pull request Aug 22, 2024
Open
@github-actions github-actions bot added the Component - Core Affects the Core module label Aug 22, 2024
@paulgessinger paulgessinger mentioned this pull request Aug 22, 2024
Merged
1 task
@andiwand
Copy link
Contributor

Somehow we encountered this all three at the same time @paulgessinger @benjaminhuth #3533

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

📊: Physics performance monitoring for 27f1094

Full contents

physmon summary

@kodiakhq kodiakhq bot merged commit e5fa01e into acts-project:main Aug 23, 2024
41 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@acts-project-service
Copy link
Collaborator

✅ Athena integration test results [e5fa01e]

✅ All tests successful

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 test_ActsDumpGeometryIdentifiers
🟢 test_ActsCheckObjectCountsCachedWorkflow
🟢 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_unit_tests

@paulgessinger paulgessinger modified the milestones: next, v36.2.0 Aug 26, 2024
kodiakhq bot pushed a commit that referenced this pull request Aug 26, 2024
@paulgessinger
feat(geo): Gen3 portal links (#3531)
7735d2d 
Part of #3502 

- [x] Change `resolveVolume` return type to `Result<const TrackingVolume*>`

Blocked by:
- #3542
- #3544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module
Projects
None yet
Milestone
v36.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @andiwand @acts-project-service