Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GeoModel conversion for TGC, sTGC and MicroMega #3540

Merged
merged 171 commits into from
Aug 30, 2024

Conversation

Berggren-Jonas
Copy link
Contributor

This PR adds some additional usability to my previous one. I added a GeoSimplePolygonBrep converter for the conversion of (s)TGCs. In addition I added unit testing for the conversion of GeoTube, GeoTrd and GeoSimplePolygonBrep with four and six vertices.

Here are some examples of the converter:
python3 geomodel_vol.py -i ~/ATLAS-R3-MUONTEST_v3.db -q Muon --output-obj -o muons -n MM actMicroMegaGas yields
mm_converted00

For (s)TGCs we can use python3 geomodel_vol.py -i ~/ATLAS-R3-MUONTEST_v3.db -q Muon --output-obj -o muons -n TGC TgcGas to get
converted_tgc00

Matthew Harris and others added 30 commits June 3, 2024 08:14
@github-actions github-actions bot removed the Infrastructure Changes to build tools, continous integration, ... label Aug 27, 2024
@dimitra97
Copy link
Contributor

Some comments that were left in the code...otherwise looks good!
@Berggren-Jonas I see some things are commonly touched here and also in the new pr #3576 that is now draft. I guess we should merge this one first and then pull and adapt it to your other recent pr :) so maybe some of my comments are common here and there

@andiwand andiwand marked this pull request as draft August 30, 2024 09:02
@andiwand andiwand marked this pull request as ready for review August 30, 2024 09:07
Copy link

@kodiakhq kodiakhq bot merged commit 2b106ca into acts-project:main Aug 30, 2024
42 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 31, 2024
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants