-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GeoModel conversion for TGC, sTGC and MicroMega #3540
Conversation
Co-authored-by: Benjamin Huth <[email protected]>
Co-authored-by: Benjamin Huth <[email protected]>
…ers.hpp Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
…rSurfaceFactory.hpp Co-authored-by: Andreas Stefl <[email protected]>
Some comments that were left in the code...otherwise looks good! |
|
This PR adds some additional usability to my previous one. I added a
GeoSimplePolygonBrep
converter for the conversion of (s)TGCs. In addition I added unit testing for the conversion ofGeoTube
,GeoTrd
andGeoSimplePolygonBrep
with four and six vertices.Here are some examples of the converter:
![mm_converted00](https://private-user-images.githubusercontent.com/93843498/360488807-080bc34f-65a6-4432-be2b-2a8728b28cbe.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDE1MjAsIm5iZiI6MTczOTQ0MTIyMCwicGF0aCI6Ii85Mzg0MzQ5OC8zNjA0ODg4MDctMDgwYmMzNGYtNjVhNi00NDMyLWJlMmItMmE4NzI4YjI4Y2JlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDEwMDcwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNkMzk0Njc5ZmZkMzRiOGRkNWExMzk5ZmY1ODcwY2YwYmY1ZDdiYmQxN2NjNDc2YzYyYjE2ZDFmM2JjODUxNTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.b2yndAHok2Rm95p2b4XMwfV1gg2vDjrATnkSCTxuYD8)
python3 geomodel_vol.py -i ~/ATLAS-R3-MUONTEST_v3.db -q Muon --output-obj -o muons -n MM actMicroMegaGas
yieldsFor (s)TGCs we can use
![converted_tgc00](https://private-user-images.githubusercontent.com/93843498/360501072-3c6cb2e8-2ccd-4e90-939e-e9738acf67e1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDE1MjAsIm5iZiI6MTczOTQ0MTIyMCwicGF0aCI6Ii85Mzg0MzQ5OC8zNjA1MDEwNzItM2M2Y2IyZTgtMmNjZC00ZTkwLTkzOWUtZTk3MzhhY2Y2N2UxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDEwMDcwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBiODY3NjcyYTMwYjNhZGU0NTk0Yjc0MTA0YjU2M2E1OWY3ZjI5ODg3NzZmMTMxYjFjZDZkZGI5ZmUzNWRhOTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Usi_V5TFooG-no2cFYnePJThovurU14ERYF-u-O5Gm8)
python3 geomodel_vol.py -i ~/ATLAS-R3-MUONTEST_v3.db -q Muon --output-obj -o muons -n TGC TgcGas
to get