feat: GeoModelDetectorObjectFactory for flexible conversion of GeoModel objects to Acts Surfaces and Volumes #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Benjamin Huth <[email protected]>
Co-authored-by: Benjamin Huth <[email protected]>
…ers.hpp Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
…rSurfaceFactory.hpp Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Paul Gessinger <[email protected]>
Co-authored-by: Paul Gessinger <[email protected]>
github-actions
bot
removed
the
Infrastructure
paulgessinger
approved these changes
Aug 22, 2024
|
|
I think there are a bunch of |
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
After #3499, a few clang-tidy issues snuck into `main`. I'm fixing them here.
|
@andiwand my bad, fixed in separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
GeoModelDetectorObjectFacotythat converts a variety of GeoModel elements to Acts elements in a flexible manner.geomodel_vol.py. It takes a number of optional parameters to select what and how to convert.python3 geomodel_vol.py -i ATLAS-R3-MUONTEST_v3.db -q Pixel SCT --output-obj -o id -ml Siliconconverts theFullPhysVolelements of the ID toActs::SensitiveSurfacepython3 geomodel_vol.py -i ATLAS-R3-MUONTEST_v3.db -q Muon --output-obj -o muons -ml RPCgas Aluminium --convert-boundingboxes MDT -n RpcGasGap Tube BML1_RPC11_1_3_1_1_2 BML1_MDT03_1_3_1converts the gas gaps of the specified RPC toActs::SensitivSurfaceelements. In addition it converts theFullPhysVolof the specified MDT toActs::Experimental::DetectorVolumecontaining the tubes asActs::Surfaceelements."@wip ready for review"