Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix proto layer range for straw surfaces #3443

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

XiaocongAi
Copy link
Contributor

This PR fixes the problem when obtaining the extent of a layer with straw surfaces. When the lseg of a straw surface is 1, the number of vertices of the polyhedron representation is 3, which makes the detail::VerticesHelper::onHyperPlane here and the detail::VerticesHelper::isInsidePolygon here return true and further set the rMin of the extent to zero (here), which is problematic for straw layers.

@github-actions github-actions bot added the Component - Core Affects the Core module label Jul 25, 2024
@XiaocongAi XiaocongAi force-pushed the fix-straw-layer-range branch from a3af29c to 7bbb68c Compare July 25, 2024 11:15
@AJPfleger AJPfleger added this to the next milestone Jul 25, 2024
@asalzburger asalzburger self-requested a review July 29, 2024 08:23
Copy link

@kodiakhq kodiakhq bot merged commit 6423d1c into acts-project:main Jul 29, 2024
46 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jul 29, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants