Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve CKF error handling and fix path limit abortion #3436

Merged

Conversation

andiwand
Copy link
Contributor

In the CKF we rely on a custom path limit handling and want to disable the one from the propagator. I think this was the case once with StubPathLimitReached being there but might have been overwritten with a merge failure.

Apart from that I tweak the error handling again to propagate them to the user.

@andiwand andiwand added this to the next milestone Jul 24, 2024
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright as far as I can tell.

@paulgessinger paulgessinger marked this pull request as ready for review July 25, 2024 06:34
Copy link

@kodiakhq kodiakhq bot merged commit 518782e into acts-project:main Jul 25, 2024
46 checks passed
@andiwand andiwand deleted the fix-ckf-path-limit-and-error-handling branch July 25, 2024 10:59
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jul 25, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants