Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Single tree for RootMeasurementWriter #3417

Merged
merged 11 commits into from
Jul 23, 2024
Merged

refactor: Single tree for RootMeasurementWriter #3417

merged 11 commits into from
Jul 23, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Jul 19, 2024 •
edited
Loading

  • Single root tree for all measurements
  • Move tree implementation to source
  • Residuals and pulls

@andiwand andiwand added this to the next milestone Jul 19, 2024
@andiwand andiwand requested a review from benjaminhuth July 19, 2024 08:54
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Jul 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

📊: Physics performance monitoring for f4e757f

Full contents

physmon summary

paulgessinger
paulgessinger reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some CI failures remain related to outputs, I think.

Examples/Io/Root/include/ActsExamples/Io/Root/RootMeasurementWriter.hpp Show resolved Hide resolved
Examples/Io/Root/src/RootMeasurementWriter.cpp Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
24 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit df0e54d into acts-project:main Jul 23, 2024
44 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [df0e54d]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 23, 2024
@andiwand andiwand deleted the refactor-rootmeasurementwriter branch July 23, 2024 18:54
@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

@benjaminhuth benjaminhuth Awaiting requested review from benjaminhuth

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Changes Performance Component - Examples Affects the Examples module
Projects
None yet
Milestone
v36.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andiwand @acts-project-service @paulgessinger