Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Explicit checkPathLength and isValid intersection check #3416

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

andiwand
Copy link
Contributor

  • Rename checkIntersection to checkPathLength
    • Remove templating
  • Add isValid to intersection objects
    • Will remove the boolean conversion in the future

@andiwand andiwand added this to the next milestone Jul 19, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Jul 19, 2024
@andiwand andiwand requested a review from benjaminhuth July 19, 2024 08:22
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just a few comments

Core/include/Acts/Utilities/Intersection.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Utilities/Intersection.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Utilities/Intersection.hpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Component - Fatras Affects the Fatras module label Jul 19, 2024
@andiwand andiwand requested a review from benjaminhuth July 19, 2024 12:48
@andiwand andiwand changed the title refactor: Explicit checkPathLength and valid intersection check refactor: Explicit checkPathLength and isValid intersection check Jul 22, 2024
@kodiakhq kodiakhq bot merged commit 64d681b into acts-project:main Jul 22, 2024
43 checks passed
@andiwand andiwand deleted the refactor-check-interseaction branch July 22, 2024 19:06
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 22, 2024
Copy link

@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Fatras Affects the Fatras module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants