Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix and refactor digitization parametrization in Examples #3386

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

andiwand
Copy link
Contributor

  • Exact was not serialized correctly
  • Add sigma to Exact as 0 breaks reconstruction
  • Configure GaussTrunc and GaussClipped range in terms of sigma

@andiwand andiwand added this to the next milestone Jul 15, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Jul 15, 2024
benjaminhuth
benjaminhuth previously approved these changes Jul 15, 2024
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andiwand andiwand dismissed stale reviews from paulgessinger and benjaminhuth via 41fc07e July 15, 2024 20:44
Copy link

@kodiakhq kodiakhq bot merged commit b4c888d into acts-project:main Jul 16, 2024
46 checks passed
@andiwand andiwand deleted the ex-refactor-digitization-params branch July 16, 2024 08:26
@acts-project-service
Copy link
Collaborator

acts-project-service commented Jul 16, 2024

🔴 Athena integration test results [b4c888d]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 16, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.0.0 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants