Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Downgrade Pythia8 to v10 from v12 #3384

Merged
merged 8 commits into from
Jul 15, 2024

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Jul 15, 2024

Fixes reproducibility issue.

This is to see if it fixes our reproducibility issue.
@paulgessinger paulgessinger added this to the v36.0.0 milestone Jul 15, 2024
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Jul 15, 2024
@github-actions github-actions bot added Component - Examples Affects the Examples module Changes Performance labels Jul 15, 2024
@paulgessinger paulgessinger marked this pull request as ready for review July 15, 2024 12:10
.github/workflows/builds.yml Outdated Show resolved Hide resolved
.github/workflows/builds.yml Outdated Show resolved Hide resolved
.github/workflows/builds.yml Outdated Show resolved Hide resolved
@paulgessinger
Copy link
Member Author

@andiwand I made the tag 53 now, and I'll just bump all CI images to that version to keep it consistent.

benjaminhuth
benjaminhuth previously approved these changes Jul 15, 2024
@andiwand andiwand changed the title ci: Downgrade Pythia8 to v10 from v12 fix: Downgrade Pythia8 to v10 from v12 Jul 15, 2024
benjaminhuth
benjaminhuth previously approved these changes Jul 15, 2024
benjaminhuth
benjaminhuth previously approved these changes Jul 15, 2024
@paulgessinger
Copy link
Member Author

paulgessinger commented Jul 15, 2024

It failed on GitLab now. We didn't bump the images there yet I guess.

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. I think you need to force merge since I pushed already

Copy link

@paulgessinger paulgessinger merged commit 6821b04 into acts-project:main Jul 15, 2024
44 checks passed
@paulgessinger paulgessinger deleted the ci/pythia-downgrade branch July 15, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants