Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Move context from PropagatorOptions to propagate #3378

Closed

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Jul 13, 2024

After the refactor of PropagatorOptions in #3181 I realized during the Athena integration that we sometimes rely on PropagatorOptions objects being constructed before we have a context at had. Options do not necessarily need to hold the geometry and magnetic field context. Usually we pass those in via function parameters which makes sense as these objects might be temporary and we do not control their lifetime so we should not hold on to them in structs.

In consecutive PRs I would like to align stepper, navigator, actors and algorithm options too.

@andiwand andiwand added the 🚧 WIP Work-in-progress label Jul 13, 2024
@andiwand andiwand added this to the v36.0.0 milestone Jul 13, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Fatras Affects the Fatras module Component - Examples Affects the Examples module Vertexing Track Finding Track Fitting labels Jul 13, 2024
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module 🚧 WIP Work-in-progress Track Finding Track Fitting Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant