refactor!: Move context from PropagatorOptions
to propagate
#3378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the refactor of
PropagatorOptions
in #3181 I realized during the Athena integration that we sometimes rely onPropagatorOptions
objects being constructed before we have a context at had. Options do not necessarily need to hold the geometry and magnetic field context. Usually we pass those in via function parameters which makes sense as these objects might be temporary and we do not control their lifetime so we should not hold on to them in structs.In consecutive PRs I would like to align stepper, navigator, actors and algorithm options too.