-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gen2 navigation debugged #3365
Merged
kodiakhq
merged 10 commits into
acts-project:main
from
asalzburger:feat-gen2-navigation
Jul 12, 2024
Merged
feat: gen2 navigation debugged #3365
kodiakhq
merged 10 commits into
acts-project:main
from
asalzburger:feat-gen2-navigation
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for bb37091physmon summary
|
andiwand
reviewed
Jul 11, 2024
Examples/Algorithms/Propagation/include/ActsExamples/Propagation/PropagationOptions.hpp
Outdated
Show resolved
Hide resolved
andiwand
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR establishes the Gen-2 navigation for the ODD and ITk detector.
I also deletes left-over dead code.
x-y view of central ITk:
R-z view of ITK:
Attention:
there is one change to the Propagagtor so physmom needs to be checked carefully