Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gen2 navigation debugged #3365

Merged
merged 10 commits into from
Jul 12, 2024

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Jul 11, 2024

This PR establishes the Gen-2 navigation for the ODD and ITk detector.

I also deletes left-over dead code.

x-y view of central ITk:

Screenshot 2024-07-11 at 15 21 49

R-z view of ITK:

Screenshot 2024-07-11 at 15 22 12

Attention:
there is one change to the Propagagtor so physmom needs to be checked carefully

@asalzburger asalzburger added this to the next milestone Jul 11, 2024
@asalzburger asalzburger requested a review from andiwand July 11, 2024 13:23
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module labels Jul 11, 2024
@asalzburger asalzburger requested a review from andiwand July 12, 2024 07:03
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

Copy link

@kodiakhq kodiakhq bot merged commit def01ad into acts-project:main Jul 12, 2024
52 checks passed
@paulgessinger paulgessinger deleted the feat-gen2-navigation branch July 12, 2024 10:56
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [def01ad]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 12, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.0.0 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants