Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch macOS build to use CMake-based dependencies #3346

Merged
merged 34 commits into from
Jul 8, 2024

Conversation

paulgessinger
Copy link
Member

No description provided.

@paulgessinger paulgessinger added this to the v36.0.0 milestone Jul 3, 2024
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Jul 3, 2024
@paulgessinger paulgessinger force-pushed the ci/macos-deps-update branch from 0dc1e1e to 867b6f2 Compare July 5, 2024 11:47
@github-actions github-actions bot added Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins labels Jul 6, 2024
@github-actions github-actions bot removed Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins labels Jul 6, 2024
@paulgessinger
Copy link
Member Author

The build now terminates with

CMake Error in Plugins/Geant4/CMakeLists.txt:
  Target "ActsPluginGeant4" INTERFACE_INCLUDE_DIRECTORIES property contains
  path:
    "/Users/runner/work/acts/acts/install/geant4/11.1.3/include/Geant4"
  which is prefixed in the source directory.
CMake Error in Plugins/Json/CMakeLists.txt:
  Target "ActsPluginJson" INTERFACE_INCLUDE_DIRECTORIES property contains
  path:
    "/Users/runner/work/acts/acts/install/nlohmann_json/3.11.2/include"
  which is prefixed in the source directory.
CMake Error in Plugins/Json/CMakeLists.txt:
  Target "ActsPluginJson" INTERFACE_INCLUDE_DIRECTORIES property contains
  path:
    "/Users/runner/work/acts/acts/install/nlohmann_json/3.11.2/include"
  which is prefixed in the source directory.
-- Generating done (0.5s)
CMake Generate step failed.  Build files cannot be regenerated correctly.

which I don't really understand. I tested this locally, and even if I change the install directory (relocate), it doesn't produce this error.

@github-actions github-actions bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Jul 8, 2024
@paulgessinger paulgessinger marked this pull request as ready for review July 8, 2024 12:18
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kodiakhq kodiakhq bot merged commit e4f3d90 into acts-project:main Jul 8, 2024
49 checks passed
@github-actions github-actions bot removed the automerge label Jul 8, 2024
@paulgessinger paulgessinger deleted the ci/macos-deps-update branch July 8, 2024 16:27
Copy link

sonarqubecloud bot commented Jul 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants