refactor(gx2f): change type of Gx2fnUpdateColumn to uint32_t (athena compatability) #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
📊: Physics performance monitoring for 8d7341ephysmon summary
|
|
andiwand
approved these changes
Jun 28, 2024
| @@ -1006,7 +1006,7 @@ class Gx2Fitter { | |||
| if (trackContainer.hasColumn( | |||
| Acts::hashString(Gx2fConstants::gx2fnUpdateColumn))) { | |||
| ACTS_DEBUG("Add nUpdate to track") | |||
| track.template component<std::size_t>("Gx2fnUpdateColumn") = nUpdate; | |||
| track.template component<std::uint32_t>("Gx2fnUpdateColumn") = nUpdate; | |||
There was a problem hiding this comment.
SonarQube points out that this is an implicit conversion, which could potentially have made explicit here.
acts-project-service
added
the
Breaks Athena build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
size_t-columns are not supported in athena. This should be fine for the fitter, since we don't expect values larger than 2000 or so to be in there. Usually we have values around 4-6.