Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump cmakeperf version to work around numpy issue #3314

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

paulgessinger
Copy link
Member

This bumps cmakeperf to 2a409b5, which should hopefully fix the numpy issues with v2.0

@paulgessinger paulgessinger added this to the v36.0.0 milestone Jun 20, 2024
@paulgessinger paulgessinger requested a review from AJPfleger June 20, 2024 07:28
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Jun 20, 2024
@AJPfleger AJPfleger linked an issue Jun 20, 2024 that may be closed by this pull request
@AJPfleger
Copy link
Contributor

Side note:
I get WARNING: Did not find branch or tag '2a409b5', assuming revision or ref.. It seems there is no way to explicitly tell, that we are looking for a commits. Only way to prevent failure is to not have branches/tag name-clashing with commit hashes in the repo.

Nothing to do/change here, just interesting git-behaviour that was new to me.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.27%. Comparing base (cbaf5a1) to head (2b5e4b8).
Report is 262 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3314   +/-   ##
=======================================
  Coverage   47.27%   47.27%           
=======================================
  Files         510      510           
  Lines       30095    30095           
  Branches    14605    14605           
=======================================
  Hits        14226    14226           
  Misses       5377     5377           
  Partials    10492    10492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger
Copy link
Member Author

@AJPfleger I think this message comes from pip, not git itself.

@kodiakhq kodiakhq bot merged commit e440b62 into acts-project:main Jun 20, 2024
51 checks passed
timadye pushed a commit to andiwand/acts that referenced this pull request Jun 27, 2024
)

This bumps cmakeperf to 2a409b5, which should hopefully fix the numpy issues with v2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: job build_performance fails after numpy 2.0.0 release
3 participants