Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gx2f): clean up logging before material PR #3294

Merged
merged 8 commits into from
Jun 15, 2024

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger added the 🛑 blocked This item is blocked by another item label Jun 14, 2024
@AJPfleger AJPfleger added this to the next milestone Jun 14, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Jun 14, 2024
@AJPfleger AJPfleger marked this pull request as draft June 14, 2024 15:07
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 47.31%. Comparing base (e1a76b3) to head (ffe0f07).
Report is 268 commits behind head on main.

Files with missing lines Patch % Lines
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 30.76% 0 Missing and 9 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3294   +/-   ##
=======================================
  Coverage   47.31%   47.31%           
=======================================
  Files         512      512           
  Lines       30434    30434           
  Branches    14794    14793    -1     
=======================================
+ Hits        14399    14400    +1     
  Misses       5402     5402           
+ Partials    10633    10632    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AJPfleger AJPfleger marked this pull request as ready for review June 14, 2024 19:30
@AJPfleger AJPfleger requested a review from andiwand June 14, 2024 19:33
@AJPfleger AJPfleger removed the 🛑 blocked This item is blocked by another item label Jun 14, 2024
@kodiakhq kodiakhq bot merged commit 06c2b63 into acts-project:main Jun 15, 2024
53 checks passed
@AJPfleger AJPfleger deleted the cleanup branch June 15, 2024 07:49
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jun 15, 2024
@andiwand andiwand modified the milestones: next, v35.2.0 Jun 16, 2024
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
timadye pushed a commit to andiwand/acts that referenced this pull request Jun 27, 2024
kodiakhq bot pushed a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants