fix: Early exit in the seeding if there are no space points for top/bottom… #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
approved these changes
Jun 13, 2024
📊: Physics performance monitoring for 8577c19physmon summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3284 +/- ##
==========================================
- Coverage 47.37% 47.36% -0.01%
==========================================
Files 511 511
Lines 30254 30260 +6
Branches 14679 14680 +1
==========================================
Hits 14333 14333
- Misses 5383 5389 +6
Partials 10538 10538 ☔ View full report in Codecov by Sentry. |
LuisFelipeCoelho
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Thanks for fixing this @CarloVarni. It looks good to me. Do you know if this improves the CPU performance? Maybe for high-pileup it doesn't change much?
I suspect a very minimal improvement, and only for single particle cases. |
|
Just flickered the |
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jun 14, 2024
…ottom… (acts-project#3284) The following cut in the code was supposed to allow for an early exit of the code in case there are no space points that can be used as bottom or top candidates ```cpp if (state.bottomNeighbours.size() == 0 || state.topNeighbours.size() == 0) ``` Too bad this was buggy and it was always false, since those arrays were always filled even if there were no space points. This PR fixes it, since now the arrays `state.topNeighbours` and `state.bottomNeighbours` are filled only if the bin contains entries.
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
…ottom… (acts-project#3284) The following cut in the code was supposed to allow for an early exit of the code in case there are no space points that can be used as bottom or top candidates ```cpp if (state.bottomNeighbours.size() == 0 || state.topNeighbours.size() == 0) ``` Too bad this was buggy and it was always false, since those arrays were always filled even if there were no space points. This PR fixes it, since now the arrays `state.topNeighbours` and `state.bottomNeighbours` are filled only if the bin contains entries.
timadye
pushed a commit
to andiwand/acts
that referenced
this pull request
Jun 27, 2024
…ottom… (acts-project#3284) The following cut in the code was supposed to allow for an early exit of the code in case there are no space points that can be used as bottom or top candidates ```cpp if (state.bottomNeighbours.size() == 0 || state.topNeighbours.size() == 0) ``` Too bad this was buggy and it was always false, since those arrays were always filled even if there were no space points. This PR fixes it, since now the arrays `state.topNeighbours` and `state.bottomNeighbours` are filled only if the bin contains entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following cut in the code was supposed to allow for an early exit of the code in case there are no space points that can be used as bottom or top candidates
Too bad this was buggy and it was always false, since those arrays were always filled even if there were no space points. This PR fixes it, since now the arrays
state.topNeighboursandstate.bottomNeighboursare filled only if the bin contains entries.