Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Exclude Examples tests from Core tests, phony target #3279

Merged
merged 10 commits into from
Jun 13, 2024

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Jun 12, 2024

This PR tries to untangle the "Core" unit tests from the examples build.

@paulgessinger paulgessinger added this to the v35.1.0 milestone Jun 12, 2024
@github-actions github-actions bot added Component - Fatras Affects the Fatras module Component - Examples Affects the Examples module labels Jun 12, 2024
benjaminhuth
benjaminhuth previously approved these changes Jun 12, 2024
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only one comment about comments. Feel free to ignore it. The PR title does not reflect the cmake change, but this is of course not super important.

Tests/UnitTests/CMakeLists.txt Outdated Show resolved Hide resolved
@paulgessinger paulgessinger changed the title build: Move JSON digi test code to JSON unit test build: Exclude Examples tests from Core tests, phony target Jun 12, 2024
@paulgessinger
Copy link
Member Author

@benjaminhuth thanks! Should be updated now.

@paulgessinger
Copy link
Member Author

Hang on, I found another problem with this. Approach. Need to think about it.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.36%. Comparing base (2877323) to head (e80bcc4).
Report is 272 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3279   +/-   ##
=======================================
  Coverage   47.36%   47.36%           
=======================================
  Files         511      511           
  Lines       30260    30260           
  Branches    14680    14680           
=======================================
  Hits        14333    14333           
  Misses       5389     5389           
  Partials    10538    10538           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger paulgessinger force-pushed the build/examples-tests branch from 5d1a4fe to b0c8f67 Compare June 13, 2024 11:31
@paulgessinger
Copy link
Member Author

New approach, can you have another look @benjaminhuth?

@github-actions github-actions bot added the Component - Documentation Affects the documentation label Jun 13, 2024
benjaminhuth
benjaminhuth previously approved these changes Jun 13, 2024
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

docs/getting_started.md Outdated Show resolved Hide resolved
benjaminhuth
benjaminhuth previously approved these changes Jun 13, 2024
@paulgessinger
Copy link
Member Author

@benjaminhuth had to add one more fix to the getting started page, and adjust the cmake option parsing so I can get the desired output.
Can you have another quick look?

@paulgessinger paulgessinger modified the milestones: v35.1.0, v35.2.0 Jun 13, 2024
@kodiakhq kodiakhq bot merged commit c57e13a into acts-project:main Jun 13, 2024
51 checks passed
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
…ject#3279)

This PR tries to untangle the "Core" unit tests from the examples build.

Co-authored-by: Benjamin Huth <[email protected]>
timadye pushed a commit to andiwand/acts that referenced this pull request Jun 27, 2024
…ject#3279)

This PR tries to untangle the "Core" unit tests from the examples build.

Co-authored-by: Benjamin Huth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants