-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Exclude Examples tests from Core tests, phony target #3279
build: Exclude Examples tests from Core tests, phony target #3279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only one comment about comments. Feel free to ignore it. The PR title does not reflect the cmake change, but this is of course not super important.
@benjaminhuth thanks! Should be updated now. |
📊: Physics performance monitoring for e80bcc4physmon summary
|
Hang on, I found another problem with this. Approach. Need to think about it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3279 +/- ##
=======================================
Coverage 47.36% 47.36%
=======================================
Files 511 511
Lines 30260 30260
Branches 14680 14680
=======================================
Hits 14333 14333
Misses 5389 5389
Partials 10538 10538 ☔ View full report in Codecov by Sentry. |
5d1a4fe
to
b0c8f67
Compare
New approach, can you have another look @benjaminhuth? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@benjaminhuth had to add one more fix to the getting started page, and adjust the cmake option parsing so I can get the desired output. |
…ject#3279) This PR tries to untangle the "Core" unit tests from the examples build. Co-authored-by: Benjamin Huth <[email protected]>
…ject#3279) This PR tries to untangle the "Core" unit tests from the examples build. Co-authored-by: Benjamin Huth <[email protected]>
This PR tries to untangle the "Core" unit tests from the examples build.