fix: codecov coverage badge - correct branch #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for b7be42dphysmon summary
|
dimitra97
approved these changes
May 31, 2024
acts-project-service
added
the
Fails Athena tests
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
After - acts-project#3108 the badge did not update anymore. This was due to the wrong branch setting, after copying the suggestion from codecov. This removes any branch-specification and takes the default branch from ACTS. Since the documentation of codecov is not super clear, it might be necessary also to add a token in the future like this: ``` [](https://codecov.io/gh/acts-project/acts) ``` The token (different from the upload token) can be found at https://app.codecov.io/gh/acts-project/acts/settings/badge (login required). It seems to work without token for now, so no reason to expose it to the public.
](https://codecov.io/gh/acts-project/acts){kind=link}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3232 +/- ##
=======================================
Coverage 47.60% 47.60%
=======================================
Files 507 507
Lines 29137 29137
Branches 13976 13976
=======================================
Hits 13871 13871
Misses 5268 5268
Partials 9998 9998 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
the badge did not update anymore. This was due to the wrong branch setting, after copying the suggestion from codecov. This removes any branch-specification and takes the default branch from ACTS.
Since the documentation of codecov is not super clear, it might be necessary also to add a token in the future like this:
The token (different from the upload token) can be found at https://app.codecov.io/gh/acts-project/acts/settings/badge (login required). It seems to work without token for now, so no reason to expose it to the public.