-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update CI job to newer OS (drop ubuntu 20.04, centos7/8) #3227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we want to go with 24 already. The majority of users might still be using 22 for a while
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3227 +/- ##
==========================================
+ Coverage 47.24% 47.44% +0.19%
==========================================
Files 508 508
Lines 30041 29066 -975
Branches 14586 14098 -488
==========================================
- Hits 14192 13789 -403
+ Misses 5375 5183 -192
+ Partials 10474 10094 -380 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 079140ephysmon summary
|
I'd actually go so far as to be adventurous and add a C++23 CI job based on the Ubuntu 24.04 image. 😄 |
We should definitely keep a 22.04 job for now. |
Yes, dropping 22.04 was never in question. That's why we plan:
|
@gagnonlg, we were discussing to remove the |
Fine by me @AJPfleger |
I bumped histcmp to v0.6.6, where the python upper limit is removed. Let's see what that does. Aside from this, the hash changes are likely expected, and physmon changes likely as well. |
I have possible fixes:
|
I updated the hashes again from Github, but it seems unfortunately they still disagree between Github and the Gitlab CI runs. I believe the matched previously. Not sure what to make of this yet. |
After another round they seem to agree now? Maybe I was looking at the wrong pair of jobs. |
Ok now we're down to a few FPEs that were not previously observed it seems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get it in!
Sonar cloud complains about the fpe-fix, but since we had the nested logic before, we could ignore it? |
@AJPfleger I would ignore that for right now, yeah. |
|
As already mentioned in the last meetings, we would like to update our testing matrix.
Please check if you rely on Ubuntu 20.04 or Centos 7&8. We plan to remove those from the testing in the next few weeks, if no-one comes forward with strong reasons to keep them.
Updateplan
Change Ubuntu 22.04 -> 24.04
Change Ubuntu 20.04 -> 22.04
Remove Centos 7
Remove Centos 8
blocked by: