Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update CI job to newer OS (drop ubuntu 20.04, centos7/8) #3227

Merged
merged 37 commits into from
Jul 5, 2024

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented May 27, 2024

As already mentioned in the last meetings, we would like to update our testing matrix.

Please check if you rely on Ubuntu 20.04 or Centos 7&8. We plan to remove those from the testing in the next few weeks, if no-one comes forward with strong reasons to keep them.

Updateplan

Change Ubuntu 22.04 -> 24.04
Change Ubuntu 20.04 -> 22.04
Remove Centos 7
Remove Centos 8

blocked by:

@AJPfleger AJPfleger added this to the next milestone May 27, 2024
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label May 27, 2024
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to go with 24 already. The majority of users might still be using 22 for a while

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.44%. Comparing base (cf9d872) to head (281d3cb).
Report is 16 commits behind head on main.

Current head 281d3cb differs from pull request most recent head 83a05e4

Please upload reports for the commit 83a05e4 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3227      +/-   ##
==========================================
+ Coverage   47.24%   47.44%   +0.19%     
==========================================
  Files         508      508              
  Lines       30041    29066     -975     
  Branches    14586    14098     -488     
==========================================
- Hits        14192    13789     -403     
+ Misses       5375     5183     -192     
+ Partials    10474    10094     -380     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephenswat
Copy link
Member

I'd actually go so far as to be adventurous and add a C++23 CI job based on the Ubuntu 24.04 image. 😄

@AJPfleger AJPfleger changed the title ci: Switch main CI job to Ubuntu 24.04 ci: Update CI job to newer OS (drop ubuntu 20.04, centos7/8) Jun 11, 2024
@github-actions github-actions bot added the Component - Documentation Affects the documentation label Jun 18, 2024
@paulgessinger
Copy link
Member

We should definitely keep a 22.04 job for now.

@AJPfleger
Copy link
Contributor Author

Yes, dropping 22.04 was never in question. That's why we plan:

  • Change Ubuntu 20.04 -> 22.04

@AJPfleger
Copy link
Contributor Author

@gagnonlg, we were discussing to remove the linux-nodeps-build. Would this be ok for you or do you think we should still test for the boost-edge-case?

@gagnonlg
Copy link
Contributor

gagnonlg commented Jul 1, 2024

@gagnonlg, we were discussing to remove the linux-nodeps-build. Would this be ok for you or do you think we should still test for the boost-edge-case?

Fine by me @AJPfleger

@paulgessinger
Copy link
Member

paulgessinger commented Jul 3, 2024

I bumped histcmp to v0.6.6, where the python upper limit is removed. Let's see what that does.

Aside from this, the hash changes are likely expected, and physmon changes likely as well.

@paulgessinger
Copy link
Member

I have possible fixes:

  • Use 51 instead of v51 in the GitLab CI config
  • Use clang-tidy-18 directly from the Ubuntu 24.04 repository instead of installing from llvm. I believe this also simplifies the toolchain configuration. Let's see what the full CI run says.

@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Track Finding labels Jul 4, 2024
@paulgessinger
Copy link
Member

I updated the hashes again from Github, but it seems unfortunately they still disagree between Github and the Gitlab CI runs. I believe the matched previously. Not sure what to make of this yet.

@paulgessinger
Copy link
Member

After another round they seem to agree now? Maybe I was looking at the wrong pair of jobs.

@paulgessinger
Copy link
Member

Ok now we're down to a few FPEs that were not previously observed it seems.

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in!

@AJPfleger
Copy link
Contributor Author

Sonar cloud complains about the fpe-fix, but since we had the nested logic before, we could ignore it?

@paulgessinger
Copy link
Member

@AJPfleger I would ignore that for right now, yeah.

@kodiakhq kodiakhq bot merged commit c85848d into acts-project:main Jul 5, 2024
50 checks passed
@github-actions github-actions bot removed the automerge label Jul 5, 2024
Copy link

sonarqubecloud bot commented Jul 5, 2024

@AJPfleger AJPfleger deleted the update-machines branch July 8, 2024 00:01
kodiakhq bot pushed a commit that referenced this pull request Jul 13, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.0.0 Jul 18, 2024
@AJPfleger AJPfleger mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Infrastructure Changes to build tools, continous integration, ... Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants