-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Explicit nullptr
checks in Navigator
#3218
refactor: Explicit nullptr
checks in Navigator
#3218
Conversation
📊: Physics performance monitoring for 4fe47ecphysmon summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm \(^○^)人(^○^)/
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3218 +/- ##
=======================================
Coverage 47.61% 47.61%
=======================================
Files 507 507
Lines 29163 29167 +4
Branches 13996 14000 +4
=======================================
+ Hits 13885 13889 +4
Misses 5260 5260
Partials 10018 10018 ☔ View full report in Codecov by Sentry. |
There are a couple of implicit `bool` conversions in the `Navigator` which I propose to replace with explicit `nullptr` comparisons to improve readability.
There are a couple of implicit `bool` conversions in the `Navigator` which I propose to replace with explicit `nullptr` comparisons to improve readability.
There are a couple of implicit
bool
conversions in theNavigator
which I propose to replace with explicitnullptr
comparisons to improve readability.