Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Explicit nullptr checks in Navigator #3218

Conversation

andiwand
Copy link
Contributor

There are a couple of implicit bool conversions in the Navigator which I propose to replace with explicit nullptr comparisons to improve readability.

@andiwand andiwand added this to the next milestone May 24, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label May 24, 2024
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm \(^○^)人(^○^)/

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.61%. Comparing base (d7aa303) to head (4fe47ec).
Report is 249 commits behind head on main.

Files Patch % Lines
Core/include/Acts/Propagator/Navigator.hpp 83.33% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3218   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files         507      507           
  Lines       29163    29167    +4     
  Branches    13996    14000    +4     
=======================================
+ Hits        13885    13889    +4     
  Misses       5260     5260           
  Partials    10018    10018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 538a1fa into acts-project:main May 25, 2024
52 checks passed
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label May 25, 2024
@andiwand andiwand deleted the refactor-navigator-explicit-nullptr-pointer-checks branch May 25, 2024 06:37
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label May 29, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 31, 2024
There are a couple of implicit `bool` conversions in the `Navigator` which I propose to replace with explicit `nullptr` comparisons to improve readability.
@andiwand andiwand modified the milestones: next, v35.1.0 Jun 1, 2024
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
There are a couple of implicit `bool` conversions in the `Navigator` which I propose to replace with explicit `nullptr` comparisons to improve readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants