ci: bump codecov-action to v4 #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Infrastructure
📊: Physics performance monitoring for 5dffa49physmon summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3215 +/- ##
==========================================
- Coverage 49.14% 47.51% -1.63%
==========================================
Files 499 499
Lines 29253 28292 -961
Branches 13870 13832 -38
==========================================
- Hits 14375 13442 -933
- Misses 4969 4970 +1
+ Partials 9909 9880 -29 ☔ View full report in Codecov by Sentry. |
andiwand
approved these changes
May 24, 2024
|
Force merged - as it will fail CI. |
kodiakhq bot
referenced
this pull request
May 24, 2024
Follow up to `https://github.com/acts-project/acts/pull/3215`. The base did not get uploaded to codecov. Therefore, the difference-problem is handed over to the next PR. We need to provide the token to successfully upload. We increase the accepted threshold to update the codecov-BASE over the course of 2 PRs, to get PRs (including this one) in until the upload problem is solved.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
## Issue For about a week, we did not get any coverage reports added to PRs. Reason was a failing upload, due to the codecov rate limit. `[2024-05-24T09:08:19.271Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2453s.', code='throttled')}` ## Solution - Update from `codecov-action@v3` to `codecov-action@v4`. To keep the same coverage, we need to add the flag `disable_search: true`. Otherwise, around 1500 coverage files would be uploaded and increase our coverage from 50% to 85%. This solution was suggested in: - codecov/codecov-action#1354 Maybe we need to add the token as `token: ${{ secrets.CODECOV_TOKEN }}`, when we run into the rate-limit again. But it might not necessary, since they enabled token-free uploads for forks of open-source repositories. ## Coverage Change -1.63% The change seems to be due to 2 reasons: - The old HEAD lies 14 commits in the past - Ending `}` are not counted as "covered" and just ignored. Therefore the relative amount of uncovered parts is increased.
EleniXoch
referenced
this pull request
in EleniXoch/acts
May 31, 2024
…t#3222) Follow up to `https://github.com/acts-project/acts/pull/3215`. The base did not get uploaded to codecov. Therefore, the difference-problem is handed over to the next PR. We need to provide the token to successfully upload. We increase the accepted threshold to update the codecov-BASE over the course of 2 PRs, to get PRs (including this one) in until the upload problem is solved.
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
## Issue For about a week, we did not get any coverage reports added to PRs. Reason was a failing upload, due to the codecov rate limit. `[2024-05-24T09:08:19.271Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2453s.', code='throttled')}` ## Solution - Update from `codecov-action@v3` to `codecov-action@v4`. To keep the same coverage, we need to add the flag `disable_search: true`. Otherwise, around 1500 coverage files would be uploaded and increase our coverage from 50% to 85%. This solution was suggested in: - codecov/codecov-action#1354 Maybe we need to add the token as `token: ${{ secrets.CODECOV_TOKEN }}`, when we run into the rate-limit again. But it might not necessary, since they enabled token-free uploads for forks of open-source repositories. ## Coverage Change -1.63% The change seems to be due to 2 reasons: - The old HEAD lies 14 commits in the past - Ending `}` are not counted as "covered" and just ignored. Therefore the relative amount of uncovered parts is increased.
Matthewharri
referenced
this pull request
in Matthewharri/acts
Jun 18, 2024
…t#3222) Follow up to `https://github.com/acts-project/acts/pull/3215`. The base did not get uploaded to codecov. Therefore, the difference-problem is handed over to the next PR. We need to provide the token to successfully upload. We increase the accepted threshold to update the codecov-BASE over the course of 2 PRs, to get PRs (including this one) in until the upload problem is solved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
For about a week, we did not get any coverage reports added to PRs.
Reason was a failing upload, due to the codecov rate limit.
[2024-05-24T09:08:19.271Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2453s.', code='throttled')}Solution - Update from
codecov-action@v3tocodecov-action@v4.To keep the same coverage, we need to add the flag
disable_search: true. Otherwise, around 1500 coverage files would be uploaded and increase our coverage from 50% to 85%. This solution was suggested in:Maybe we need to add the token as
token: ${{ secrets.CODECOV_TOKEN }}, when we run into the rate-limit again. But it might not necessary, since they enabled token-free uploads for forks of open-source repositories.Coverage Change -1.63%
The change seems to be due to 2 reasons:
}are not counted as "covered" and just ignored. Therefore the relative amount of uncovered parts is increased.