feat: Manual Propagator initialization and AnySurfaceReached aborter
#3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
changed the title
Propagator initializationPropagator initialization and AnySurfaceReached aborter
📊: Physics performance monitoring for 742743aphysmon summary
|
andiwand
commented
May 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3208 +/- ##
=======================================
Coverage 47.59% 47.59%
=======================================
Files 507 507
Lines 29135 29137 +2
Branches 13976 13976
=======================================
+ Hits 13866 13869 +3
- Misses 5268 5269 +1
+ Partials 10001 9999 -2 ☔ View full report in Codecov by Sentry. |
benjaminhuth
previously approved these changes
May 27, 2024
There was a problem hiding this comment.
lgtm, I do not yet start merging to wait for @ssdetlab approval
|
Hi @andiwand, @benjaminhuth. The changes look reasonable to me. Maybe add a small comment clarifying that the |
acts-project-service
added
the
Fails Athena tests
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
…ter (acts-project#3208) This allows to manually initialize the propagation so `propagate(state)` can be called multiple times without destruction of the state in-between. I also added an `AnySurfaceReached` aborter which, in combination with the other change, allows users to jump from surface to surface using the same propagator state without any resets.
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
…ter (acts-project#3208) This allows to manually initialize the propagation so `propagate(state)` can be called multiple times without destruction of the state in-between. I also added an `AnySurfaceReached` aborter which, in combination with the other change, allows users to jump from surface to surface using the same propagator state without any resets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to manually initialize the propagation so
propagate(state)can be called multiple times without destruction of the state in-between. I also added anAnySurfaceReachedaborter which, in combination with the other change, allows users to jump from surface to surface using the same propagator state without any resets.