Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reverse track finding for Examples #3200

Merged
merged 15 commits into from
Jul 25, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented May 21, 2024

We would like to run part of our seeds for track finding in Athena first inwards and then outwards. First we wanted to showcase this using the Acts Examples framework. Since we do not really have multiple seed regions in the Examples right now this is modeled as a static config flag in the track finding.

blocked by

@andiwand andiwand added this to the next milestone May 21, 2024
@github-actions github-actions bot added Component - Examples Affects the Examples module Track Finding labels May 21, 2024
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label May 22, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label May 22, 2024
@andiwand andiwand added the 🛑 blocked This item is blocked by another item label May 22, 2024
@github-actions github-actions bot removed the Component - Core Affects the Core module label May 22, 2024
@andiwand andiwand removed the 🛑 blocked This item is blocked by another item label May 24, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.62%. Comparing base (4745e24) to head (4fba19d).
Report is 83 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3200   +/-   ##
=======================================
  Coverage   47.62%   47.62%           
=======================================
  Files         507      507           
  Lines       29173    29173           
  Branches    14000    14000           
=======================================
  Hits        13893    13893           
  Misses       5260     5260           
  Partials    10020    10020           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added Stale and removed Stale labels Jun 26, 2024
@andiwand andiwand marked this pull request as ready for review July 23, 2024 08:27
@andiwand andiwand marked this pull request as draft July 23, 2024 08:57
@github-actions github-actions bot removed the Infrastructure Changes to build tools, continous integration, ... label Jul 24, 2024
@andiwand andiwand requested a review from timadye July 24, 2024 07:05
@andiwand andiwand marked this pull request as ready for review July 24, 2024 07:05
Copy link
Contributor

@noemina noemina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. CI passes successfully.

Copy link

@kodiakhq kodiakhq bot merged commit f164b56 into acts-project:main Jul 25, 2024
49 of 73 checks passed
@andiwand andiwand deleted the ex-feat-reverse-ckf branch July 25, 2024 14:36
@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants