feat: Smearing for straw surfaces #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Fatras
📊: Physics performance monitoring for e30952bphysmon summary
|
…ircle.json delete json file that is not used
andiwand
reviewed
May 21, 2024
Tests/UnitTests/Fatras/Digitization/UncorrelatedHitSmearerTests.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Andreas Stefl <[email protected]>
delete cout
andiwand
approved these changes
May 22, 2024
acts-project-service
added
the
Fails Athena tests
kodiakhq bot
pushed a commit
that referenced
this pull request
May 24, 2024
This PR fixes the previous PR I opened with the straw surfaces smearing #3197 because I realized that the` forcePositiveValues` parameter from json is not parsed successfully, since I did not add them in the `JsonConfiguration`. I am fixing with this PR (hopefully).
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
This PR introduces the smearing of the` boundParameters` of Straw Surface, that can be used for a fast digitization approach for the MDTs with a Gaussian distribution. It is configures from the json structure that can be used for the creation of a json file for a full propagation-digitization test. Also the option for positive only values is introduced in the `SmearingConfig` as a flag because for the case of the drift radius we want to get only positive values as output.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
…#3216) This PR fixes the previous PR I opened with the straw surfaces smearing acts-project#3197 because I realized that the` forcePositiveValues` parameter from json is not parsed successfully, since I did not add them in the `JsonConfiguration`. I am fixing with this PR (hopefully).
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
This PR introduces the smearing of the` boundParameters` of Straw Surface, that can be used for a fast digitization approach for the MDTs with a Gaussian distribution. It is configures from the json structure that can be used for the creation of a json file for a full propagation-digitization test. Also the option for positive only values is introduced in the `SmearingConfig` as a flag because for the case of the drift radius we want to get only positive values as output.
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
…#3216) This PR fixes the previous PR I opened with the straw surfaces smearing acts-project#3197 because I realized that the` forcePositiveValues` parameter from json is not parsed successfully, since I did not add them in the `JsonConfiguration`. I am fixing with this PR (hopefully).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the smearing of the
boundParametersof Straw Surface, that can be used for a fast digitization approach for the MDTs with a Gaussian distribution. It is configures from the json structure that can be used for the creation of a json file for a full propagation-digitization test.Also the option for positive only values is introduced in the
SmearingConfigas a flag because for the case of the drift radius we want to get only positive values as output.