Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: removing PlanarCluster, PlanarClusterization, IdenficiationModule and… #3177

Merged
merged 13 commits into from
May 8, 2024

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented May 8, 2024

Spring cleaning campaign - part 1

This PR removes the redundant

  • Core/Digitization ( replaced by Fatras/Digitization since long ago)
  • Plugins/IdentificationModule (only there to add the DigitizationModule and Identifier to detector elements)
  • PlanarCluster infrastructure (replaced by Measurement)

Such as the associated Algorithm, helpers and I/O modules in Examples

This is marked BREAKING because it removes a component (albeit unused from Core).

It also moves the Identifier definition into the relevant detector elements.

@asalzburger asalzburger added this to the next milestone May 8, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins SP formation labels May 8, 2024
@asalzburger asalzburger force-pushed the chore-remove-planar-module branch from c22c72b to fcd877d Compare May 8, 2024 09:29
@github-actions github-actions bot added the Component - Documentation Affects the documentation label May 8, 2024
@asalzburger
Copy link
Contributor Author

@osbornjd - I tag you on this one, because I think this will have (small) implications for sPHENIX - as you use the TGeo geometry infrastructure.

Botton line, I removed the intermediate IdentifiedDetectorElement in order to get rid of 4k lines of unused code, we still have the same functionality, I just shifted the Identifier into the TGeoElement definition instead.

@andiwand andiwand modified the milestones: next, v36.0.0 May 8, 2024
@asalzburger asalzburger requested a review from andiwand May 8, 2024 12:40
@osbornjd
Copy link
Contributor

osbornjd commented May 8, 2024

Thanks for the heads up. I think this actually shouldn't affect us too much as our experiment specific detector element class inherits directly from the TGeoDetectorElement. So it may be completely transparent to us...

@andiwand andiwand modified the milestones: v36.0.0, v35.0.0 May 8, 2024
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@andiwand andiwand modified the milestones: v35.0.0, next May 8, 2024
@kodiakhq kodiakhq bot merged commit 6ba0582 into acts-project:main May 8, 2024
51 checks passed
@github-actions github-actions bot removed the automerge label May 8, 2024
@asalzburger asalzburger deleted the chore-remove-planar-module branch May 8, 2024 18:29
@andiwand andiwand modified the milestones: next, v35.0.0 May 17, 2024
asalzburger added a commit to asalzburger/acts that referenced this pull request May 21, 2024
…dule and… (acts-project#3177)

**Spring cleaning campaign - part 1**

This PR removes the redundant
* `Core/Digitization` ( replaced by `Fatras/Digitization` since long ago)
* `Plugins/IdentificationModule` (only there to add the DigitizationModule and Identifier to detector elements)
* `PlanarCluster` infrastructure (replaced by `Measurement`)

Such as the associated Algorithm, helpers and I/O modules in `Examples`

This is marked *BREAKING* because it removes a component (albeit unused from `Core`).

It also moves the `Identifier` definition into the relevant detector elements.
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
…dule and… (acts-project#3177)

**Spring cleaning campaign - part 1**

This PR removes the redundant 
* `Core/Digitization` ( replaced by `Fatras/Digitization` since long ago)
* `Plugins/IdentificationModule` (only there to add the DigitizationModule and Identifier to detector elements)
* `PlanarCluster` infrastructure (replaced by `Measurement`)

Such as the associated Algorithm, helpers and I/O modules in `Examples`


This is marked *BREAKING* because it removes a component (albeit unused from `Core`).

It also moves the `Identifier` definition into the relevant detector elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins SP formation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants