-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: removing PlanarCluster, PlanarClusterization, IdenficiationModule and… #3177
chore!: removing PlanarCluster, PlanarClusterization, IdenficiationModule and… #3177
Conversation
… DigitizationModule
c22c72b
to
fcd877d
Compare
@osbornjd - I tag you on this one, because I think this will have (small) implications for sPHENIX - as you use the TGeo geometry infrastructure. Botton line, I removed the intermediate |
📊: Physics performance monitoring for 55def06physmon summary
|
Thanks for the heads up. I think this actually shouldn't affect us too much as our experiment specific detector element class inherits directly from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
…dule and… (acts-project#3177) **Spring cleaning campaign - part 1** This PR removes the redundant * `Core/Digitization` ( replaced by `Fatras/Digitization` since long ago) * `Plugins/IdentificationModule` (only there to add the DigitizationModule and Identifier to detector elements) * `PlanarCluster` infrastructure (replaced by `Measurement`) Such as the associated Algorithm, helpers and I/O modules in `Examples` This is marked *BREAKING* because it removes a component (albeit unused from `Core`). It also moves the `Identifier` definition into the relevant detector elements.
…dule and… (acts-project#3177) **Spring cleaning campaign - part 1** This PR removes the redundant * `Core/Digitization` ( replaced by `Fatras/Digitization` since long ago) * `Plugins/IdentificationModule` (only there to add the DigitizationModule and Identifier to detector elements) * `PlanarCluster` infrastructure (replaced by `Measurement`) Such as the associated Algorithm, helpers and I/O modules in `Examples` This is marked *BREAKING* because it removes a component (albeit unused from `Core`). It also moves the `Identifier` definition into the relevant detector elements.
Spring cleaning campaign - part 1
This PR removes the redundant
Core/Digitization
( replaced byFatras/Digitization
since long ago)Plugins/IdentificationModule
(only there to add the DigitizationModule and Identifier to detector elements)PlanarCluster
infrastructure (replaced byMeasurement
)Such as the associated Algorithm, helpers and I/O modules in
Examples
This is marked BREAKING because it removes a component (albeit unused from
Core
).It also moves the
Identifier
definition into the relevant detector elements.