Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove SourceLinkAccessorConcept #3171

Merged
merged 1 commit into from
May 6, 2024
Merged

refactor: Remove SourceLinkAccessorConcept #3171

merged 1 commit into from
May 6, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented May 6, 2024

This does not seem to be used anymore

@andiwand andiwand added this to the next milestone May 6, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Track Finding labels May 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

📊: Physics performance monitoring for 2f7bffa

Full contents

physmon summary

@kodiakhq kodiakhq bot merged commit 5a00e86 into acts-project:main May 6, 2024
54 checks passed
@github-actions github-actions bot removed the automerge label May 6, 2024
@acts-project-service
Copy link
Collaborator

acts-project-service commented May 6, 2024 •
edited
Loading

✅ Athena integration test results [5a00e86]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsConversionWorkflow
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label May 6, 2024
@andiwand andiwand deleted the remove-sourcelinkaccessorconecpt branch May 7, 2024 08:11
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label May 7, 2024
@andiwand andiwand modified the milestones: next, v35.0.0 May 17, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@andiwand @asalzburger
refactor: Remove SourceLinkAccessorConcept (acts-project#3171)
84feb6d 
This does not seem to be used anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests Track Finding
Projects
None yet
Milestone
v35.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andiwand @acts-project-service @AJPfleger