-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make Geant4 surface mapper configurable #3157
Merged
kodiakhq
merged 9 commits into
acts-project:main
from
asalzburger:feat-digitizer-takes-surfaces
Apr 30, 2024
Merged
feat: make Geant4 surface mapper configurable #3157
kodiakhq
merged 9 commits into
acts-project:main
from
asalzburger:feat-digitizer-takes-surfaces
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for e50a05cphysmon summary
|
andiwand
reviewed
Apr 29, 2024
Examples/Algorithms/Geant4/include/ActsExamples/Geant4/SensitiveSurfaceMapper.hpp
Show resolved
Hide resolved
Examples/Algorithms/Geant4/include/ActsExamples/Geant4/SensitiveSurfaceMapper.hpp
Show resolved
Hide resolved
andiwand
approved these changes
Apr 30, 2024
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
This PR breaks the direct dependency of `ActsExamples::Geant4Simulation` from `TrackingGeometry` and allows to set a customised SensitiveSurface mapper. The current SensitiveSurface mapper would fail for e.g. ITK geometry because the center comparison would probably not be valid. Also, it allows to test with Gen2 geometry, which will be needed (for the moment) for the `traccc` input simulation.
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
This PR breaks the direct dependency of `ActsExamples::Geant4Simulation` from `TrackingGeometry` and allows to set a customised SensitiveSurface mapper. The current SensitiveSurface mapper would fail for e.g. ITK geometry because the center comparison would probably not be valid. Also, it allows to test with Gen2 geometry, which will be needed (for the moment) for the `traccc` input simulation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks the direct dependency of
ActsExamples::Geant4Simulation
fromTrackingGeometry
and allows to set a customised SensitiveSurface mapper.The current SensitiveSurface mapper would fail for e.g. ITK geometry because the center comparison would probably not be valid. Also, it allows to test with Gen2 geometry, which will be needed (for the moment) for the
traccc
input simulation.