Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make Geant4 surface mapper configurable #3157

Merged
merged 9 commits into from
Apr 30, 2024

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Apr 29, 2024

This PR breaks the direct dependency of ActsExamples::Geant4Simulation from TrackingGeometry and allows to set a customised SensitiveSurface mapper.

The current SensitiveSurface mapper would fail for e.g. ITK geometry because the center comparison would probably not be valid. Also, it allows to test with Gen2 geometry, which will be needed (for the moment) for the traccc input simulation.

@asalzburger asalzburger added this to the next milestone Apr 29, 2024
@asalzburger asalzburger requested a review from andiwand April 29, 2024 14:59
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Apr 29, 2024
@asalzburger asalzburger requested a review from andiwand April 30, 2024 07:18
@kodiakhq kodiakhq bot merged commit 992d86d into acts-project:main Apr 30, 2024
51 checks passed
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
This PR breaks the direct dependency of `ActsExamples::Geant4Simulation` from `TrackingGeometry` and allows to set a customised SensitiveSurface mapper.

The current SensitiveSurface mapper would fail for e.g. ITK geometry because the center comparison would probably not be valid. Also, it allows to test with Gen2 geometry, which will be needed (for the moment) for the `traccc` input simulation.
@andiwand andiwand modified the milestones: next, v35.0.0 May 17, 2024
asalzburger added a commit to asalzburger/acts that referenced this pull request May 21, 2024
This PR breaks the direct dependency of `ActsExamples::Geant4Simulation` from `TrackingGeometry` and allows to set a customised SensitiveSurface mapper.

The current SensitiveSurface mapper would fail for e.g. ITK geometry because the center comparison would probably not be valid. Also, it allows to test with Gen2 geometry, which will be needed (for the moment) for the `traccc` input simulation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants