-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix EigenStepper
step upscaling
#3152
fix: Fix EigenStepper
step upscaling
#3152
Conversation
EigenStepper
step upscaling when necessaryEigenStepper
step upscaling
📊: Physics performance monitoring for f95a01bphysmon summary
|
EigenStepper
step upscalingEigenStepper
step upscaling
This is blocked for now because I had to work around a navigation issue which should be resolved before this goes in |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3152 +/- ##
=======================================
Coverage ? 47.62%
=======================================
Files ? 507
Lines ? 29172
Branches ? 14000
=======================================
Hits ? 13894
Misses ? 5259
Partials ? 10019 ☔ View full report in Codecov by Sentry. |
The `EigenStepper` should use the same formula for up and downscaling the step size. Also according to https://cds.cern.ch/record/1113528/files/ATL-SOFT-PUB-2009-001.pdf we should use a factor 4 as a margin for rejecting the attempted step.
The `EigenStepper` should use the same formula for up and downscaling the step size. Also according to https://cds.cern.ch/record/1113528/files/ATL-SOFT-PUB-2009-001.pdf we should use a factor 4 as a margin for rejecting the attempted step.
The
EigenStepper
should use the same formula for up and downscaling the step size. Also according to https://cds.cern.ch/record/1113528/files/ATL-SOFT-PUB-2009-001.pdf we should use a factor 4 as a margin for rejecting the attempted step.