Implement getters for named file fields #2021
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
I wanted to change
ContentDisposition
to always beattachment
no matter the underlying file type. But since there is currently no way to retrieve the current content disposition ofNamedFile
, I would have to guess thefilename
parameter for this header.And since the other fields might also potentially be interesting to users, getter methods for those were added as well.
Open questions
I did not add
pub fn flags(&self) -> &Flags
, because having the bit mask is quite meaningless without knowing what the bits stand for. Since there is noset_flags
setter either, should we add methods likepub fn is_FLAG_set(&self) -> bool
? For example,pub fn is_etag_set(&self) -> bool
?