properly drop h2 connection

[fakeshadow]

PR Type

Bug Fix

PR Checklist

• Documentation comments have been added / updated.
• Format code with the latest stable rustfmt.
• (Team) Label with affected crates and semver status.

Overview

Wake up h2::client::Connection and resolve it's task when dropping h2::client::SendRequest

Closes #1123

[robjtede]

Is there a sensible test case (even manual) for this or wsa fix verified using the code sample from the issue?

[fakeshadow]

Is there a sensible test case (even manual) for this or wsa fix verified using the code sample from the issue?

I want to rework this use the join handle instead of a custom drop type with channel.
Test would be added with it

[fakeshadow]

@robjtede
I notice join handle is not export in the current actix-rt master branch use. So I add a test for manual drop and JoinHandle can be a future goal for refactor.

[robjtede]

huh? https://github.com/actix/actix-net/blob/master/actix-rt/src/lib.rs#L94

[fakeshadow]

huh? https://github.com/actix/actix-net/blob/master/actix-rt/src/lib.rs#L94

Sorry my English is garbage. What I meant to say was actix-rt is pinned to 2.0.0-beta.2 in actix-web repo where JoinHandle is still not export yet.

[robjtede]

much cleaner with the join handle approach, nice job