-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Component / Composable testing #1015
Conversation
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
I noticed the Organizations page doesn't seem to be working for me. I'm not sure if I broke it, my computer is just slow, or it got broken in main. Let me know if you want to get on a call tomorrow or sometime soon to see what is happening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All's working great, @cquinn540! Thanks so much for getting us started with component testing! 🚀 Really is amazing to finally see this up and running 😊
Contributor checklist
Description
This adds some happy path tests for a composable for fetching images based on the color mode and the sign-in flow.
This also solves some issues where Nuxt plugins don't work in a vitest environment by default, so I have re-injected them into the vitest environment and mocked them where necessary.
Currently there is a limitation with Nuxt's endpoint mocking that you cannot change the status code, preventing me from testing errors. I think I can set up a test server to get around that, but I think that would make this pull request too big, and would be good as a separate issue.
Related issue