Add support for Rails 5.2.1 #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-yagi
force-pushed
the
support-rails-5-2-1
branch
from
aaaa8da to
8a1f2cf
Compare
|
@y-yagi Thanks for working on this! |
y-yagi
force-pushed
the
support-rails-5-2-1
branch
3 times, most recently
from
ce8e685 to
d3f7ac4
Compare
Management of alias tracker has changed in rails/rails@50036e6. So fixed accordingly with it.
y-yagi
force-pushed
the
support-rails-5-2-1
branch
from
d3f7ac4 to
bd55fb1
Compare
|
Seems test all passed. I removed WIP. |
|
Thank you @y-yagi ! |
|
@y-yagi Is this PR related to this? #942 if so, please, release a new version of gem with this fix. Possible related issues: rails/rails#33557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Management of alias tracker has changed in rails/rails@50036e6.
So fixed accordingly with it.