Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout v2: add l2/l3 #5385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Checkout v2: add l2/l3 #5385

wants to merge 1 commit into from

Conversation

gasb150
Copy link
Collaborator

@gasb150 gasb150 commented Jan 20, 2025

Summary

This adds the L2/L3 fields required in purchase, authorize and capture transactions

SER-1554

Unit Tests

Finished in 0.282324 seconds.
70 tests, 481 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote Tests

Finished in 164.547288 seconds.
116 tests, 280 assertions, 7 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 93.9655% passed

Rubocop

806 files inspected, no offenses detected

Copy link
Collaborator

@javierpedrozaing javierpedrozaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job, I left some comments for you consideration.

lib/active_merchant/billing/gateways/checkout_v2.rb Outdated Show resolved Hide resolved
test/remote/gateways/remote_checkout_v2_test.rb Outdated Show resolved Hide resolved
test/unit/gateways/checkout_v2_test.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@Heavyblade Heavyblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is pretty much ok @gasb150, left some minor comments and question

lib/active_merchant/billing/gateways/checkout_v2.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/checkout_v2.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/checkout_v2.rb Outdated Show resolved Hide resolved
test/remote/gateways/remote_checkout_v2_test.rb Outdated Show resolved Hide resolved
Summary
----------------
This adds the L2/L3 fields required in purchase, authorize and capture transactions

[SER-1554](https://spreedly.atlassian.net/browse/SER-1554)

Unit Tests
----------------
Finished in 0.282324 seconds.
70 tests, 481 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote Tests
----------------
Finished in 164.547288 seconds.
116 tests, 280 assertions, 7 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
93.9655% passed

Rubocop
----------------
806 files inspected, no offenses detected
@gasb150 gasb150 force-pushed the SER-1554_l2_l3_checkout_v2 branch from 44d18ca to f5df0d9 Compare January 21, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants