CheckoutV2: Add Amount Allocations object

[justingrobles]

Description

Add Amount Allocations object for Sub-Entity payments as Marketplace object is deprecated.

Referrence

• Checkout: Process Sub Entity Payments

LOCAL: rake test:local TEST=test/unit/gateways/checkout_v2_test.rb
Finished in 0.020203 seconds.
-----------------------------------------------------------------------------------------------------------------------------------
68 tests, 431 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-----------------------------------------------------------------------------------------------------------------------------------
3365.84 tests/s, 21333.47 assertions/s

REMOTE: rake test:remote TEST=test/remote/gateways/remote_checkout_v2_test.rb
- Update fixtures (Checkout Keys), three (3) processing_channel_id and entity_id.

Finished in 169.233266 seconds.
-----------------------------------------------------------------------------------------------------------------------------------
113 tests, 267 assertions, 15 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
86.7257% passed
-----------------------------------------------------------------------------------------------------------------------------------
0.67 tests/s, 1.58 assertions/s

Test Failed (Existing based on Test against Master):
- test_expired_card_returns_error_code
- test_failed_purchase
- test_invalid_shipping_address
- test_money_transfer_payout_handles_blank_destination_address
- test_money_transfer_payout_reverts_to_credit_if_payout_sent_as_nil
- test_successful_authorize_includes_avs_result
- test_successful_credit
- test_successful_money_transfer_payout_via_credit_corporate_account_holder_type
- test_successful_money_transfer_payout_via_credit_individual_account_holder_type
- test_successful_purchase_includes_avs_result
- test_successful_purchase_with_ip
- test_successful_purchase_with_minimal_options
- test_successful_purchase_with_processing_data
- test_successful_purchase_with_shipping_address
- test_successful_purchase_without_phone_number

Test on Master

LOCAL: rake test:local TEST=test/unit/gateways/checkout_v2_test.rb
Finished in 0.017151 seconds.
-----------------------------------------------------------------------------------------------------------------------------------
67 tests, 420 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-----------------------------------------------------------------------------------------------------------------------------------
3906.48 tests/s, 24488.37 assertions/s

REMOTE: rake test:remote TEST=test/remote/gateways/remote_checkout_v2_test.rb
- Update fixtures (Checkout Keys) and three (3) processing_channel_id.

===================================================================================================================================
Finished in 172.939637 seconds.
-----------------------------------------------------------------------------------------------------------------------------------
113 tests, 267 assertions, 15 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
86.7257% passed
-----------------------------------------------------------------------------------------------------------------------------------
0.65 tests/s, 1.54 assertions/s

Failed Test
- test_expired_card_returns_error_code
- test_failed_purchase
- test_invalid_shipping_address
- test_money_transfer_payout_handles_blank_destination_address
- test_money_transfer_payout_reverts_to_credit_if_payout_sent_as_nil
- test_successful_authorize_includes_avs_result
- test_successful_credit
- test_successful_money_transfer_payout_via_credit_corporate_account_holder_type
- test_successful_money_transfer_payout_via_credit_individual_account_holder_type
- test_successful_purchase_includes_avs_result
- test_successful_purchase_with_ip
- test_successful_purchase_with_minimal_options
- test_successful_purchase_with_processing_data
- test_successful_purchase_with_shipping_address
- test_successful_purchase_without_phone_number

[github-actions]

To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you!

[AMHOL]

Not stale.

[damienjbyrne]

Hi @jduff, sorry if I'm breaking contributor protocol by tagging you directly, but I couldn't see any guidelines for this kind of etiquette in the wiki, and the Google group linked off the project page (https://activemerchant.org (Discussion)-> https://groups.google.com/g/activemerchant) looks like it hasn't been used in 6 years.

Is it possible we can ping someone to review this? Over here at Pin Payments, we need the amount_allocation object to assign payments to a Chekcout sub-entity processing channel which associates it to our processing merchant. We've been running off a branch in a private fork for a while now, waiting for this to get merged, and it's a bit of a pain keeping it updated, so getting this merged would be greatly appreciated. Thanks in advance.

[jduff]

@damienjbyrne unfortunately I don't have commit access to this project anymore so I can't really help with getting it merged. I did leave a code review in case that helps (keep in mind I haven't worked on or used this project in ~10 years).

[damienjbyrne]

Hi @almalee24, sorry to bother you directly, but could you have a look at this PR as it seems you have merge rights on the project. If I'm asking the wrong person could you tag the person I should have tagged in the first place? Thank you very much.